[USM] Add envoy configuration value #27230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitslavin
added
changelog/no-changelog
team/usm
guyarb
approved these changes
Jul 2, 2024
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=38121434 --os-family=ubuntu |
|
Issue is being handled in the following PR: #27400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add configuration value for
envoyCmd.Motivation
We currently try to determine whether a PID represents an Envoy process using this constant path:
/proc/PID/bin/envoy.We identified a situation where Envoy is being used by a symlink path that is different from this constant path.
For that reason, we have decided to use a configuration value for the Envoy path, which will allow us to update the searched path and include PIDs that are Envoy processes.
Additional Notes
I have created a follow-up task to implement path resolution and improve our current logic for identifying the Envoy process without needing a configuration value.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes